-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Max In-Flux Data During Uploads #60
Conversation
Bumps [com.github.tomakehurst:wiremock-jre8](https://github.com/wiremock/wiremock) from 2.35.0 to 2.35.1. - [Release notes](https://github.com/wiremock/wiremock/releases) - [Commits](wiremock/wiremock@2.35.0...2.35.1) --- updated-dependencies: - dependency-name: com.github.tomakehurst:wiremock-jre8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.3.5 to 1.3.12. - [Commits](qos-ch/logback@v_1.3.5...v_1.3.12) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
… - protecting the heap
…back-logback-classic-1.3.12 Bump ch.qos.logback:logback-classic from 1.3.5 to 1.3.12
….tomakehurst-wiremock-jre8-2.35.1 Bump com.github.tomakehurst:wiremock-jre8 from 2.35.0 to 2.35.1
@@ -371,6 +407,12 @@ private FusionAPIUploadOperationsBuilder uploadThreadPoolSize(int uploadThreadPo | |||
this.uploadThreadPoolSize = uploadThreadPoolSize; | |||
return this; | |||
} | |||
|
|||
@SuppressWarnings("PIT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this suppression for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Ian, false positives from PIT. Needs to be addressed in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressing this in next batch of build work. False metric being provided here.
When performing uploads ensure that we manage memory appropriately by providing a configurable parameter to protect the heap.